<html>
<head><meta charset="utf-8"><title>Can crater check warnings change? · t-compiler · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/index.html">t-compiler</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Can.20crater.20check.20warnings.20change.3F.html">Can crater check warnings change?</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="136722403"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Can%20crater%20check%20warnings%20change%3F/near/136722403" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Esteban Küber <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Can.20crater.20check.20warnings.20change.3F.html#136722403">(Oct 29 2018 at 17:41)</a>:</h4>
<p>Can crater check warnings change?<br>
I'd like to check how much noise <a href="https://github.com/rust-lang/rust/pull/55373" target="_blank" title="https://github.com/rust-lang/rust/pull/55373">https://github.com/rust-lang/rust/pull/55373</a> would cause in the ecosystem at large. Tried just keeping it as an error, but it breaks so many things (namely in this case, <code>crossbeam</code>) that cargo doesn't even get to compile.</p>



<a name="136722426"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Can%20crater%20check%20warnings%20change%3F/near/136722426" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Esteban Küber <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Can.20crater.20check.20warnings.20change.3F.html#136722426">(Oct 29 2018 at 17:41)</a>:</h4>
<p>If we can monitor output change, not just breakage then I can change it from a hard error to a warning.</p>



<a name="136722479"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Can%20crater%20check%20warnings%20change%3F/near/136722479" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Esteban Küber <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Can.20crater.20check.20warnings.20change.3F.html#136722479">(Oct 29 2018 at 17:42)</a>:</h4>
<p>otherwise we're flying blind as to how much this change will break havoc</p>



<a name="136722513"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Can%20crater%20check%20warnings%20change%3F/near/136722513" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Can.20crater.20check.20warnings.20change.3F.html#136722513">(Oct 29 2018 at 17:42)</a>:</h4>
<p>I don't think we can check warnings directly on crater</p>



<a name="136722528"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Can%20crater%20check%20warnings%20change%3F/near/136722528" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Can.20crater.20check.20warnings.20change.3F.html#136722528">(Oct 29 2018 at 17:43)</a>:</h4>
<p>we can do a run with <code>-Dlint_name</code> though</p>



<a name="136724550"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Can%20crater%20check%20warnings%20change%3F/near/136724550" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Esteban Küber <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Can.20crater.20check.20warnings.20change.3F.html#136724550">(Oct 29 2018 at 18:13)</a>:</h4>
<p>Fair enough... That could work well enough...</p>



<a name="136724564"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Can%20crater%20check%20warnings%20change%3F/near/136724564" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Esteban Küber <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Can.20crater.20check.20warnings.20change.3F.html#136724564">(Oct 29 2018 at 18:13)</a>:</h4>
<p>but I will need to change the PR to be a lint</p>



<a name="136724578"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Can%20crater%20check%20warnings%20change%3F/near/136724578" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Esteban Küber <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Can.20crater.20check.20warnings.20change.3F.html#136724578">(Oct 29 2018 at 18:13)</a>:</h4>
<p>that might take me a while...</p>



<a name="136724602"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Can%20crater%20check%20warnings%20change%3F/near/136724602" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Esteban Küber <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Can.20crater.20check.20warnings.20change.3F.html#136724602">(Oct 29 2018 at 18:13)</a>:</h4>
<p>right now the check's done where it is easier, at the macro parsing stage</p>



<a name="136724671"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Can%20crater%20check%20warnings%20change%3F/near/136724671" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Esteban Küber <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Can.20crater.20check.20warnings.20change.3F.html#136724671">(Oct 29 2018 at 18:14)</a>:</h4>
<p>thanks <span class="user-mention" data-user-id="121055">@Pietro Albini</span>, I'll go back to the drawing board and turn it into lint. It's probably what it should be regardless.</p>



<a name="136724728"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Can%20crater%20check%20warnings%20change%3F/near/136724728" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Can.20crater.20check.20warnings.20change.3F.html#136724728">(Oct 29 2018 at 18:15)</a>:</h4>
<p>another option is to just execute a run with the new PR, download all the logs and analyze it locally</p>



<a name="136725380"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Can%20crater%20check%20warnings%20change%3F/near/136725380" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Esteban Küber <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Can.20crater.20check.20warnings.20change.3F.html#136725380">(Oct 29 2018 at 18:25)</a>:</h4>
<p>Do you have a link to the docs in order to do that?</p>



<a name="136725395"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Can%20crater%20check%20warnings%20change%3F/near/136725395" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Esteban Küber <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Can.20crater.20check.20warnings.20change.3F.html#136725395">(Oct 29 2018 at 18:25)</a>:</h4>
<p>I can very easily change the PR from err to warn, turning it into a lint would take me much longer</p>



<a name="136725459"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Can%20crater%20check%20warnings%20change%3F/near/136725459" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Esteban Küber <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Can.20crater.20check.20warnings.20change.3F.html#136725459">(Oct 29 2018 at 18:26)</a>:</h4>
<p>doing a quick grep on the results would give us actionable info the quickest</p>



<a name="136725482"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Can%20crater%20check%20warnings%20change%3F/near/136725482" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Can.20crater.20check.20warnings.20change.3F.html#136725482">(Oct 29 2018 at 18:26)</a>:</h4>
<p>just start a normal run with the try toolchain</p>



<a name="136725494"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Can%20crater%20check%20warnings%20change%3F/near/136725494" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Can.20crater.20check.20warnings.20change.3F.html#136725494">(Oct 29 2018 at 18:27)</a>:</h4>
<p>then, in the report there is the "downloads" section, with a tar.gz with all the logs</p>



<a name="136725577"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Can%20crater%20check%20warnings%20change%3F/near/136725577" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Esteban Küber <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Can.20crater.20check.20warnings.20change.3F.html#136725577">(Oct 29 2018 at 18:28)</a>:</h4>
<p>Cool!</p>



<a name="136781647"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Can%20crater%20check%20warnings%20change%3F/near/136781647" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Can.20crater.20check.20warnings.20change.3F.html#136781647">(Oct 30 2018 at 14:53)</a>:</h4>
<p><span class="user-mention" data-user-id="119031">@Esteban Küber</span> wait that PR confuses me a bit</p>
<p>It claims that "Macro pattern <code>($a:expr, $b:expr)</code> is invalid, for good reason." but I think that is not true.</p>
<p>Perhaps you meant <code>$a:expr $b:expr</code>?</p>



<a name="136788825"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Can%20crater%20check%20warnings%20change%3F/near/136788825" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Esteban Küber <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Can.20crater.20check.20warnings.20change.3F.html#136788825">(Oct 30 2018 at 16:38)</a>:</h4>
<p><span class="user-mention" data-user-id="116009">@nikomatsakis</span> yep, that's indeed what I meant :)</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>